vee1e/flatbuffers
1
0
Fork 0
mirror of https://github.com/vee1e/flatbuffers.git synced 2026-09-02 02:07:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[C++] Rare bad buffer content alignment if sizeof(T) != alignof(T) (#7520)

Browse source 
* [C++] Add a failing unit test for #7516 (Rare bad buffer content alignment if sizeof(T) != alignof(T))

* [C++] Fix final buffer alignment when using an array of structs
* A struct can have an arbitrary size and therefore sizeof(struct) == alignof(struct)
  does not hold anymore as for value primitives.
* This patch fixes this by introducing alignment parameters to various
  CreateVector*/StartVector calls.
* Closes #7516
This commit is contained in:
Denis Blank 2022-09-21 20:05:05 +02:00 • committed by GitHub
parent bfceebb7fb
commit 72aa85a759
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 611 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/test.cpp
View file

@ -20,6 +20,7 @@
#include <string>
#include "evolution_test.h"
#include "alignment_test.h"
#include "flatbuffers/flatbuffers.h"
#include "flatbuffers/idl.h"
#include "flatbuffers/minireflect.h"
@ -1416,6 +1417,8 @@ int FlatBufferTests(const std::string &tests_data_path) {
SizePrefixedTest();
AlignmentTest();
#ifndef FLATBUFFERS_NO_FILE_TESTS
ParseAndGenerateTextTest(tests_data_path, false);
ParseAndGenerateTextTest(tests_data_path, true);