vee1e/flatbuffers
1
0
Fork 0
mirror of https://github.com/vee1e/flatbuffers.git synced 2026-09-01 17:57:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use correct default type for str (#8623)

Browse source 
* [Python] Use correct type for str with None

Otherwise mypy will correctly flag code like this

def __init__(self):
  self.fooBar = None  # type: Optional[str]

error: Incompatible types in assignment (expression has type "None", variable has type "str")

* [Python] Make list type optional as they can contain None
This commit is contained in:
Felix 2025-07-05 01:47:36 +02:00 • committed by GitHub
parent 6b251aa1cf
commit c15fe421ba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 61 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/idl_gen_python.cpp
View file

@ -1628,7 +1628,7 @@ class PythonGenerator : public BaseGenerator {
} else if (IsInteger(base_type)) {
return "int";
} else if (base_type == BASE_TYPE_STRING) {
return "str";
return "Optional[str]";
} else {
FLATBUFFERS_ASSERT(false && "base_type is not a scalar or string type.");
return "";
@ -1726,10 +1726,10 @@ class PythonGenerator : public BaseGenerator {
field_type = package_reference + "." + object_type + "]";
import_list->insert("import " + package_reference);
}
field_type = "List[" + field_type;
field_type = "Optional[List[" + field_type + "]";
} else {
field_type =
"List[" + GetBasePythonTypeForScalarAndString(base_type) + "]";
"Optional[List[" + GetBasePythonTypeForScalarAndString(base_type) + "]]";
}
}
@ -1769,7 +1769,7 @@ class PythonGenerator : public BaseGenerator {
}
const auto default_value = GetDefaultValue(field);
// Wrties the init statement.
// Writes the init statement.
const auto field_field = namer_.Field(field);
code += GenIndents(2) + "self." + field_field + " = " + default_value +
" # type: " + field_type;