mirror of
https://github.com/vee1e/flatbuffers.git
synced 2026-09-02 02:07:25 +00:00
c1e7aee489
* Migrate from rules_nodejs to rules_js/rules_ts (take 2) This is the second version of patch #7923. The first version got reverted because bazel query was failing: $ bazel --nosystem_rc --nohome_rc query tests(set('//...')) except tests(attr("tags", "manual", set('//...'))) ERROR: Traceback (most recent call last): File "/workdir/tests/ts/bazel_repository_test_dir/BUILD", line 6, column 22, in <toplevel> npm_link_all_packages(name = "node_modules") File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/npm/defs.bzl", line 188, column 13, in npm_link_all_packages fail(msg) Error in fail: The npm_link_all_packages() macro loaded from @npm//:defs.bzl and called in bazel package 'tests/ts/bazel_repository_test_dir' may only be called in bazel packages that correspond to the pnpm root package '' and pnpm workspace projects '' This was happening because the `.bazelrc` file only added `--deleted_packages` to the `build` command. We also need it for the `query` command. This second version of the patch fixes that. Original commit message: This patch migrates the current use of rules_nodejs to the new rules_js. rules_js is the intended replacement of rules_nodejs as per this note: https://github.com/aspect-build/rules_js#relationship-to-rules_nodejs > rules_js is an alternative to the build_bazel_rules_nodejs Bazel module > and accompanying npm packages hosted in > https://github.com/bazelbuild/rules_nodejs, which is now > unmaintained. All users are recommended to use rules_js instead. There are a few notable changes in this patch: 1. The `flatbuffer_ts_library` macro no longer accepts a `package_name` attribute. This is because rules_js appears to manage the import naming of dependencies via top-level `npm_link_package` targets. Users will have to migrate. 2. I added a few more arguments to `flatbuffer_library_public()`. These helped with exposing esbuild to `ts/compile_flat_file.sh`. 3. I pinned the version of `typescript` in `package.json` so that rules_ts can download the exact same version. rules_ts doesn't know what to do if the version isn't exact. 4. Since rules_js uses the pnpm locking mechanism, we now have a `pnpm-lock.yaml` file instead of a yarn lock file. 4. I added bazel targets for a few of the existing tests in `tests/ts`. They can be run with `bazel test //test/ts:all`. Since there is no flexbuffers bazel target, I did not add a bazel target for the corresponding test. 5. I added a separate workspace in `tests/ts/bazel_repository_test_dir/` to validate that the flatbuffers code can be imported as an external repository. You can run the test with `bazel test //test/ts:bazel_repository_test`. For this to work, I needed to expose a non-trivial chunk of the flatbuffers code to the test. I achieved this through some recursive `distribution` filegroups. This is inspired by rules_python's workspace tests. I did not do anything special to validate that the `gen_reflections` parameter works the same. This patch doesn't change anything about the TypeScript generation. As a side note: I am not an expert with rules_js. This patch is my attempt based on my limited understanding of the rule set. Fixes #7817 * Fix the query --------- Co-authored-by: Derek Bailey <derekbailey@google.com> |
||
|---|---|---|
| .. | ||
| arrays_test_complex | ||
| bazel_repository_test_dir | ||
| foobar | ||
| my-game | ||
| no_import_ext | ||
| optional-scalars | ||
| reflection | ||
| required-strings | ||
| test_dir | ||
| typescript | ||
| union_vector | ||
| bazel_repository_test.sh | ||
| BUILD.bazel | ||
| foobar.d.ts | ||
| foobar.js | ||
| foobar.ts | ||
| JavaScriptComplexArraysTest.js | ||
| JavaScriptFlexBuffersTest.js | ||
| JavaScriptRequiredStringTest.js | ||
| JavaScriptTest.js | ||
| JavaScriptTestv1.cjs | ||
| JavaScriptUnionVectorTest.js | ||
| monster_test.d.ts | ||
| monster_test.js | ||
| monster_test.ts | ||
| monster_test_generated.cjs | ||
| monsterdata_javascript_wire.mon | ||
| my-game.d.ts | ||
| my-game.js | ||
| my-game.ts | ||
| optional-scalars.ts | ||
| optional_scalars.ts | ||
| package.json | ||
| reflection.d.ts | ||
| reflection.js | ||
| reflection.ts | ||
| reflection_generated.cjs | ||
| required_strings_generated.js | ||
| required_strings_generated.ts | ||
| table-a.d.ts | ||
| table-a.js | ||
| table-a.ts | ||
| tsconfig.json | ||
| tsconfig.node.json | ||
| typescript.d.ts | ||
| typescript.js | ||
| typescript.ts | ||
| typescript_include.ts | ||
| typescript_include_generated.cjs | ||
| typescript_keywords.d.ts | ||
| typescript_keywords.fbs | ||
| typescript_keywords.js | ||
| typescript_keywords.ts | ||
| typescript_keywords_generated.cjs | ||
| typescript_transitive_include.ts | ||
| typescript_transitive_include_generated.cjs | ||
| TypeScriptTest.py | ||
| unicode_test.mon | ||