From 181dfb000bbd28ebcb7f6a603cf5c57af7ddc7ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ca=C3=ADque=20Porfirio?= <56317416+caiquejjx@users.noreply.github.com> Date: Sun, 9 Nov 2025 21:50:09 -0300 Subject: [PATCH] fix: add flush to buffered file handle (#7967) * fix: add flush to buffered file handle * chore: add changelog entry * [autofix.ci] apply automated fixes * fix: remove flush in favor of disabling buffering * fix: properly remove flush call * fix: add flush call into writer * Update mitmproxy/addons/save.py Co-authored-by: Sujal Singh * Update CHANGELOG.md --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Maximilian Hils Co-authored-by: Sujal Singh --- CHANGELOG.md | 2 ++ mitmproxy/io/io.py | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 71df2eea2..f1a957882 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ ## Unreleased: mitmproxy next +- Flush flow file after each flow to allow further processing. + ([#7967](https://github.com/mitmproxy/mitmproxy/pull/7967), @caiquejjx) - infer_content_encoding: Fallback to UTF-8 for more content types ([#7961](https://github.com/mitmproxy/mitmproxy/pull/7961), @xu-cheng) - Remove `bless` from hex editors to avoid issues with macOS diff --git a/mitmproxy/io/io.py b/mitmproxy/io/io.py index 579bd9e96..af89577d9 100644 --- a/mitmproxy/io/io.py +++ b/mitmproxy/io/io.py @@ -82,7 +82,7 @@ class FlowReader: class FilteredFlowWriter: - def __init__(self, fo, flt): + def __init__(self, fo: BinaryIO, flt: flowfilter.TFilter | None): self.fo = fo self.flt = flt @@ -91,6 +91,7 @@ class FilteredFlowWriter: return d = f.get_state() tnetstring.dump(d, self.fo) + self.fo.flush() def read_flows_from_paths(paths) -> list[flow.Flow]: