vee1e/subidx
1
0
Fork 0
mirror of https://github.com/vee1e/subidx.git synced 2026-09-01 17:57:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

tailer: account for every fetched entry and log skips

Browse source 
fetchRange counted an entry as consumed before attempting to decode
it, so undecodable entries were skipped permanently with no record,
and the position could overshoot the requested range if a log served
more entries than asked. The position now advances by exactly the
number of received entries (clamped to the range) and skips are
logged with their index window.
This commit is contained in:
lakshit verma 2026-08-21 21:38:52 +05:30
parent ab31bcee3a
commit bba101bbab
No known key found for this signature in database
1 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

16
internal/tailer/tailer.go
View file

@ -156,11 +156,11 @@ func (t *Tailer) fetchRange(ctx context.Context, client *rfc6962.Client, logID s
if len(entries) == 0 { if len(entries) == 0 {
return total, nil return total, nil
} }
decoded := int64(0) skipped := int64(0)
for _, e := range entries { for _, e := range entries {
leaf, err := rfc6962.DecodeLeafEntry(e) leaf, err := rfc6962.DecodeLeafEntry(e)
decoded++
if err != nil { if err != nil {
skipped++
continue continue
} }
fs := leaf.Timestamp fs := leaf.Timestamp
@ -170,6 +170,7 @@ func (t *Tailer) fetchRange(ctx context.Context, client *rfc6962.Client, logID s
} }
} }
if fs <= 0 { if fs <= 0 {
skipped++
continue continue
} }
for _, name := range leaf.Names { for _, name := range leaf.Names {
@ -182,8 +183,15 @@ func (t *Tailer) fetchRange(ctx context.Context, client *rfc6962.Client, logID s
} }
} }
} }
total += decoded if skipped > 0 {
pos += decoded log.Printf("tail %s: skipped %d undecodable entries in [%d,%d]", client.ShortID(), skipped, pos, end)
}
n := int64(len(entries))
if pos+n > to {
n = to - pos
}
total += n
pos += n
} }
return total, nil return total, nil
} }