Add a .style.yapf file so yapf can be used to style Python code without
passing the project's style via command line option. Remove the
corresponding patch to pigweed's call to yapf, used by CI, and instead
let it too rely on .style.yapf. Remove the developer documentation's
instruction to use the command line option.
BUG=description
The Wave pypi package was recently updated, and the new version caused
failures in our CI for pip installing it. From what I can tell, this
package is no longer being used, so this PR simply removes it as a build
dependency.
BUG=b/329887147
Pin the Bazel version used and executed by Bazelisk to guarantee that
TFLM is built with a specified version of Bazel.
When the latest release of Bazel went from version 6.3 to 7.0, our
builds, which were set to follow the latest release (because there was
no .bazelversion), were disrupted due to incompatibilities. By pinning
the Bazel version, we prevent such surprises in the future.
Revise the developer documentation to mandate the use of Bazelisk.
According to [Bazelisk documentation](9d3fc7d5e3/README.md (ensuring-that-your-developers-use-bazelisk-rather-than-bazel)),
direct installations of bazel typically use a wrapper script which
checks .bazelversion also.
BUG=see description
Clarify the guidance for linking a PR description to its bug number. The last
bullet was obsolete and confusing now that we require the specific text
`BUG=#nn`, as was mentioned in the second bullet.
BUG=see description
The bazel install script path was changed from ci/install_bazel.sh to ci/install_bazelisk.sh. This commit updates the CONTRIBUTING doc with the new path.
BUG=doc fix
* Minor update to `CONTRIBUTING.md` on cpplint installation.
`cpplint` can be installed via `pip` as well as getting a local copy.
Improving documentation to include the `pip` alternative.
* Minor update to `CONTRIBUTING.md` on cpplint installation.
`cpplint` can be installed via `pip` as well as getting a local copy.
Improving documentation to include the `pip` alternative.
BUG=
* Change pip3 to pip
Co-authored-by: Ting Yan <94130036+tingyan19@users.noreply.github.com>
* Allow using Python scripts without bazel.
Manually verified and documented the steps that I can follow to run
Python code without Bazel.
BUG=http://b/204109200
NO_CHECK_TFLITE_FILES=manually ran the sync script.
* Address review comments.
* we now accept a lot more types of contributions and have improved the documentation.
* add link to the kernel porting guide from the readme.
* small updates to the op porting guide.
* Groundwork to enable python format checks (via yapf) as part of the CI.
With this change:
* we are set up to use yapf as part of the docker container
* pigweed patch is updated to use the google Python style (pep8 with indent of 2 spaces)
* some documentation updates.
The code still needs to be formatted, and then the Python formatting check will be turned on as part of ci.
BUG=http://b/194404216
* Format all the code.
Once this change is merged, we will turn on Python formatting check as
part of the CI.
* minor formatting update.
* Turn on Python formatting checks as part of CI.
Also, add an option to fix the formatting via the test_code_style.sh
script.
BUG=http://b/194404984 and http://b/194404216
With this change:
* we are set up to use yapf as part of the docker container
* pigweed patch is updated to use the google Python style (pep8 with indent of 2 spaces)
* some documentation updates.
The code still needs to be formatted, and then the Python formatting check will be turned on as part of ci.
BUG=http://b/194404216
* check PR description for a BUG= line
* Changed file name and added some more documentation.
* move the if to be on the steo instead of at the job.
This is to allow for the job to succeed (instead of being skipped) when
the BUG= text is found. And as a result we can have it be a required
status check.
Co-authored-by: Advait Jain <advaitjain@users.noreply.github.com>
Co-authored-by: Advait Jain <advaitjain@google.com>
